Skip to content

DOCSP-37057 eloquent schema builder #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Mar 14, 2024

JIRA: https://jira.mongodb.org/browse/DOCSP-37057
Staging:

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

GromNaN and others added 29 commits February 21, 2024 15:08
* Run CI on Laravel 11
* Fix inherited param type
* Duplicate HasAttributes::getStorableEnumValue() to avoid BC break in method signature in Laravel 11 laravel/framework@8647dcf
…` operation (mongodb#2742)

Use monitoring to track if model was created or found
* 4.2:
  PHPORM-139 Implement `Model::createOrFirst()` using `findOneAndUpdate` operation (mongodb#2742)
  Test Laravel 10 and 11 (mongodb#2746)
  PHPORM-150 Run CI on Laravel 11 (mongodb#2735)
  PHPORM-152 Fix tests for Carbon 3 (mongodb#2733)
New tests require Laravel v10.47
Copy link
Contributor

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on a dense topic! Just a few suggestions and small fixes.

@ccho-mongodb ccho-mongodb force-pushed the DOCSP-37057-eloquent-schema-builder branch from 34566eb to 06dcdef Compare March 20, 2024 13:53
@ccho-mongodb ccho-mongodb requested a review from jmikola March 20, 2024 14:03
@jmikola jmikola removed their request for review March 20, 2024 18:21
@ccho-mongodb ccho-mongodb requested a review from GromNaN March 21, 2024 15:16
@GromNaN GromNaN added the docs label Mar 25, 2024
@GromNaN GromNaN changed the base branch from 4.1 to docs-rewrite March 25, 2024 16:25
@GromNaN GromNaN changed the base branch from docs-rewrite to 4.1 March 25, 2024 16:52
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccho-mongodb ccho-mongodb merged commit d4a9818 into mongodb:4.1 Mar 25, 2024
@ccho-mongodb ccho-mongodb deleted the DOCSP-37057-eloquent-schema-builder branch March 25, 2024 20:56
jmikola pushed a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants